SDK Refactor #1
Open
SDK Refactor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for karvest failed.
|
bh2smith
commented
Nov 21, 2023
|
Seems to be failing this build setup... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HookBuilderClass with hook generation and post functions.utilsandtypesandconstantsfiles.The constants file could be renamed params and also be responsible for reading env vars and choosing certain values based on chainId (e.g. settlement contract address -- although its the same on gnosis and mainnet) etc...
I am pushing into
devfor now, because I wasn't sure if we are allowed to keep working on this.